Don't expect module deps if Swift explicit modules are turned off #846
+64
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't compute module deps if Swift explicit modules are turned off for a target, but we were still setting up the `ValidateDependencies` task to expect them. rdar://161603360
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon and
owenv
as code owners
|
@swift-ci please test |
aciidgh
approved these changes
Oct 6, 2025
aciidgh
reviewed
Oct 6, 2025
| } | ||
|
|
||
| @Test(.requireSDKs(.host), .skipHostOS(.windows, "toolchain too old"), .skipHostOS(.linux, "toolchain too old")) | ||
| func validateModuleDependenciesSwiftExplicitModulesOff() async throws { |
There was a problem hiding this comment.
is it possible to parameterize this using @test?
owenv
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't compute module deps if Swift explicit modules are turned off for a target, but we were still setting up the
ValidateDependenciestask to expect them.rdar://161603360